feat: Add strptime_to_utc and strftime functions to _singerlib.utils
#1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menzenski
requested review from
edgarrmondragon,
cjohnhanson and
aaronsteers
as code owners
menzenski
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1365 +/- ##
==========================================
- Coverage 85.15% 85.13% -0.02%
==========================================
Files 53 54 +1
Lines 4668 4690 +22
Branches 794 797 +3
==========================================
+ Hits 3975 3993 +18
- Misses 503 505 +2
- Partials 190 192 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edgarrmondragon
changed the title
strptime_to_utc and strftime functions to _singerlib.utils
edgarrmondragon
approved these changes
Jan 31, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack discussion here https://meltano.slack.com/archives/C01PKLU5D1R/p1675106007009959
Context: I am trying to add Python 3.11 support to tap-tableau. Currently that tap depends on the sdk version ^0.4.5 — python 3.11 support was added in 0.13.1 so I need to bump the sdk dependency at least that far, but would like to bring it to current 0.19.0 if possible. However, one of the sdk changes made since 0.4.5 was dropping the dependency on singer-python , and this tap depends on that package (transitively via the sdk dependency). It uses that singer package to format a datetime https://github.com/GtheSheep/tap-tableau/blob/main/tap_tableau/utils.py#L6
📚 Documentation preview 📚: https://meltano-sdk--1365.org.readthedocs.build/en/1365/