Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Cookiecutter target tox ini #1438

Merged
merged 5 commits into from
Feb 22, 2023

Conversation

mkranna
Copy link
Contributor

@mkranna mkranna commented Feb 21, 2023

Issue #360: target cookiecutter has no tox.ini


📚 Documentation preview 📚: https://meltano-sdk--1438.org.readthedocs.build/en/1438/

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@6ebc5ee). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head e0af5e4 differs from pull request most recent head 39cf40e. Consider uploading reports for the commit 39cf40e to get more accurate results

@@           Coverage Diff           @@
##             main    #1438   +/-   ##
=======================================
  Coverage        ?   85.47%           
=======================================
  Files           ?       57           
  Lines           ?     4763           
  Branches        ?      808           
=======================================
  Hits            ?     4071           
  Misses          ?      501           
  Partials        ?      191           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mkranna mkranna changed the title Cookiecutter target tox ini feat: Cookiecutter target tox ini Feb 21, 2023
@mkranna mkranna marked this pull request as ready for review February 21, 2023 10:09
@tayloramurphy
Copy link
Collaborator

Thanks for the PR @mkranna - we'll have the engineering team take a look and review.

Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mkranna!

@edgarrmondragon edgarrmondragon merged commit 774a176 into meltano:main Feb 22, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants