Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: Property conformance doc typo fix #1446

Merged
merged 5 commits into from
Feb 22, 2023

Conversation

radbrt
Copy link
Contributor

@radbrt radbrt commented Feb 22, 2023

The property names of TypeConformanceLevel are NONE, RECURSIVE and ROOT_ONLY, the docstring said ROOT instead of ROOT_ONLY. Changing docstring.


📚 Documentation preview 📚: https://meltano-sdk--1446.org.readthedocs.build/en/1446/

@radbrt radbrt changed the title property conformance doc typo fix fix: property conformance doc typo fix Feb 22, 2023
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #1446 (fff7bc7) into main (3f4c0b4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1446   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files          57       57           
  Lines        4763     4763           
  Branches      808      808           
=======================================
  Hits         4071     4071           
  Misses        501      501           
  Partials      191      191           
Impacted Files Coverage Δ
singer_sdk/streams/core.py 85.88% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon changed the title fix: property conformance doc typo fix docs: Property conformance doc typo fix Feb 22, 2023
@tayloramurphy
Copy link
Collaborator

Thanks for the PR @radbrt!

@edgarrmondragon edgarrmondragon enabled auto-merge (squash) February 22, 2023 17:28
@edgarrmondragon edgarrmondragon merged commit d034b3e into meltano:main Feb 22, 2023
@radbrt radbrt deleted the conformance_typo_fix branch February 22, 2023 17:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants