Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Log warning message when JSONPath expression doesn't match anything #1609

Closed
acarter24 opened this issue Apr 14, 2023 · 2 comments · Fixed by #1999
Closed

feat: Log warning message when JSONPath expression doesn't match anything #1609

acarter24 opened this issue Apr 14, 2023 · 2 comments · Fixed by #1999
Labels
kind/Feature New feature or request valuestream/Meltano

Comments

@acarter24
Copy link

acarter24 commented Apr 14, 2023 •
edited by edgarrmondragon
Loading

Feature scope

REST Taps.

Description

As per thread here: https://meltano.slack.com/archives/C01PKLU5D1R/p1681480505968109?thread_ts=1681477300.986239&cid=C01PKLU5D1R

Child streams were not being run because parent streams were returning no results due to incorrect jsonpath, but the pagination was working correctly giving the impression of processing something!
@edgarrmondragon edgarrmondragon transferred this issue from meltano/meltano Apr 14, 2023
@edgarrmondragon edgarrmondragon changed the title feature: Log warning message when jsonpath expression doesn't match anything feat: Log warning message when JSONPath expression doesn't match anything Apr 14, 2023
@stale
Copy link

stale bot commented Aug 13, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Aug 13, 2023
@edgarrmondragon
Copy link
Collaborator

Still relevant

@edgarrmondragon edgarrmondragon linked a pull request Oct 5, 2023 that will close this issue
feat(taps): Log JSONPatch match count at the INFO level #1999
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
kind/Feature New feature or request valuestream/Meltano
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(taps): Log JSONPatch match count at the INFO level meltano/sdk
2 participants
@edgarrmondragon @acarter24