Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

BREAKING CHANGE: Consider removing usage of pendulum #1858

Closed
Tracked by #1733
edgarrmondragon opened this issue Jul 19, 2023 · 1 comment · Fixed by #2520
Closed
Tracked by #1733

BREAKING CHANGE: Consider removing usage of pendulum #1858

edgarrmondragon opened this issue Jul 19, 2023 · 1 comment · Fixed by #2520

Comments

@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented Jul 19, 2023 •
edited
Loading

  • Most recent release: Jul 24, 2020
  • No binary wheels for Python 3.10+
  • At time of writing, only prerelease 3.0.0a1 (Nov 23, 2022) has wheels for 3.10 and 3.11

The above means that anyone using an SDK-based connector in Python 3.10+ will experience slower installation times (and possibly failures), because pendulum will have to be built for their systems.

We only use it sparsely, so other than it being a breaking change, it's rather easy to tackle.
@edgarrmondragon edgarrmondragon changed the title BREAKING CHANGE: Consider removing usage of pendulum in this library BREAKING CHANGE: Consider removing usage of pendulum Jul 19, 2023
@edgarrmondragon edgarrmondragon modified the milestone: v1.0 Release Jul 21, 2023
@edgarrmondragon edgarrmondragon mentioned this issue Jul 21, 2023
Merged
1 task
@edgarrmondragon
Copy link
Collaborator Author

edgarrmondragon commented Aug 7, 2023 •
edited
Loading

There's some activity in the pendulum repo again 🤞

@edgarrmondragon edgarrmondragon mentioned this issue Jul 5, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

packaging!: Remove unused dependencies pendulum and python-dateutil meltano/sdk
1 participant
@edgarrmondragon