Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Retry SQLAlchemy engine creation for adapters without JSON SerDe support #1949

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Sep 11, 2023

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #1949 (ed8d4a6) into main (0fb0c1b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1949      +/-   ##
==========================================
+ Coverage   86.98%   87.01%   +0.02%     
==========================================
  Files          59       59              
  Lines        5093     5097       +4     
  Branches      826      826              
==========================================
+ Hits         4430     4435       +5     
+ Misses        466      465       -1     
  Partials      197      197              
Files Changed Coverage Δ
singer_sdk/connectors/sql.py 82.49% <100.00%> (+0.58%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review September 11, 2023 21:56
…re-the-sqlalchemy-adapter-doesnt-support-json-serde-parameters
@edgarrmondragon edgarrmondragon merged commit fca070e into main Sep 11, 2023
@edgarrmondragon edgarrmondragon deleted the 1945-feature-handle-cases-in-sql-plugins-where-the-sqlalchemy-adapter-doesnt-support-json-serde-parameters branch September 11, 2023 22:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Handle cases in SQL plugins where the SQLAlchemy adapter doesn't support json SerDe parameters
1 participant