Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(mappers): Respect nullability of leaf properties when flattening schema #1996

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Oct 4, 2023

Closes #1995


📚 Documentation preview 📚: https://meltano-sdk--1996.org.readthedocs.build/en/1996/

@edgarrmondragon edgarrmondragon linked an issue Oct 4, 2023 that may be closed by this pull request
@edgarrmondragon edgarrmondragon force-pushed the 1995-bug-flattening-fails-for-attributes-having-array-or-null-type branch from 69df89a to af86fb6 Compare October 4, 2023 23:13
@edgarrmondragon edgarrmondragon force-pushed the 1995-bug-flattening-fails-for-attributes-having-array-or-null-type branch from af86fb6 to cf9bd8c Compare October 4, 2023 23:31
@edgarrmondragon edgarrmondragon marked this pull request as ready for review October 4, 2023 23:46
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1996 (ff05562) into main (cb56f86) will increase coverage by 0.00%.
The diff coverage is 40.00%.

@@           Coverage Diff           @@
##             main    #1996   +/-   ##
=======================================
  Coverage   87.39%   87.40%           
=======================================
  Files          59       59           
  Lines        5126     5127    +1     
  Branches      830      830           
=======================================
+ Hits         4480     4481    +1     
  Misses        451      451           
  Partials      195      195           
Files Coverage Δ
singer_sdk/helpers/_flattening.py 72.83% <40.00%> (+0.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon changed the title fix: Respect nullability of leaf properties when flattening schema fix(mappers): Respect nullability of leaf properties when flattening schema Oct 5, 2023
@edgarrmondragon edgarrmondragon merged commit cb5ad8b into main Oct 6, 2023
24 of 25 checks passed
@edgarrmondragon edgarrmondragon deleted the 1995-bug-flattening-fails-for-attributes-having-array-or-null-type branch October 6, 2023 13:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Flattening fails for attributes having array or null type
1 participant