Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: Use fastjsonschema to validate records #2045

Closed
1 task done
edgarrmondragon opened this issue Nov 14, 2023 · 2 comments
Closed
1 task done

refactor: Use fastjsonschema to validate records #2045

edgarrmondragon opened this issue Nov 14, 2023 · 2 comments
Labels
kind/Feature New feature or request valuestream/Meltano

Comments

@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented Nov 14, 2023 •
edited
Loading

Feature scope

Other

Description

fastjsonschema seems to perform better than jsonschema.

Tasks
Preview Give feedback
  1. chore: Set up benchmarks for record schema validation #2047
    Accepting Pull Requests performance
@edgarrmondragon
Copy link
Collaborator Author

cc @BuzzCutNorman

@edgarrmondragon edgarrmondragon transferred this issue from meltano/meltano Nov 14, 2023
@BuzzCutNorman BuzzCutNorman mentioned this issue Nov 22, 2023
Closed
@edgarrmondragon
Copy link
Collaborator Author

Target devs can get this now by implementing it themselves if they're interested: #2231.

They and end users can also disable validation entirely: #2208

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
kind/Feature New feature or request valuestream/Meltano
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: Validate records with fastjsonschema BuzzCutNorman/sdk
1 participant
@edgarrmondragon