refactor(templates): Simplify tap template file names with post_gen_project.py hook

[vicmattos]

---

📚 Documentation preview 📚: https://meltano-sdk--2060.org.readthedocs.build/en/2060/

[codspeed-hq]

CodSpeed Performance Report

Merging #2060 will not alter performance

_{Comparing vicmattos:main (a9eb5a2) with main (206c38e)}

Summary

✅ 1 untouched benchmarks

[codspeed-hq]

CodSpeed Performance Report

Merging #2060 will not alter performance

_{Comparing vicmattos:main (d4f910b) with main (5b84912)}

Summary

✅ 1 untouched benchmarks

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b84912) 87.45% compared to head (5e2ab6e) 87.45%.
Report is 1 commits behind head on main.

❗ Current head 5e2ab6e differs from pull request most recent head a9eb5a2. Consider uploading reports for the commit a9eb5a2 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2060   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files          58       58           
  Lines        4861     4861           
  Branches      763      763           
=======================================
  Hits         4251     4251           
  Misses        429      429           
  Partials      181      181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[edgarrmondragon]

Thanks @vicmattos and congrats on your first contribution!

There seems to be a few things causing CI failures:

• cookiecutter/tap-template/{{cookiecutter.tap_id}}/.github/workflows/test.yml is failing causes it's not valid YAML, which is ok since it's a template but we have to configure the pre-commit hook to ignore it in:

  sdk/.pre-commit-config.yaml

  Lines 16 to 21 in 206c38e

  	- id: check-yaml
  	exclude: |
  	(?x)^(
  	cookiecutter/.*/meltano.yml|
  	cookiecutter/.*/.pre-commit-config.yaml
  	)$

• The linter is complaining about some of the imports, and some lines are longer than the allowed limit. It might be worth running the template lint checks locally to iterate over and fix the errors, (hint: run nox -rs test_cookiecutter).

[vicmattos]

Hey @edgarrmondragon! Thanks for your welcoming and feedback.

I've updated the .pre-commit-config.yaml to exclude the template files for CI.

I've also removed the changes I made inside the client files. My main goal was to simplify navigating in the cookiecutter template. I can go back to simplify their contents later.

I've ran the nox automation and seems that everything is correct. Could you double check?

[edgarrmondragon]

Thanks @vicmattos!

[edgarrmondragon]

I've also removed the changes I made inside the client files. My main goal was to simplify navigating in the cookiecutter template. I can go back to simplify their contents later.

That makes sense, do feel free to send any follow-on PRs 👍