-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: Output JSONPath expression with match count message #2118
fix: Output JSONPath expression with match count message #2118
Conversation
Sample output with: poetry run pytest tests/core/rest/test_pagination.py --log-cli-level=INFO
Open to suggestions regarding the wording of the output message |
CodSpeed Performance ReportMerging #2118 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2118 +/- ##
=======================================
Coverage 87.76% 87.76%
=======================================
Files 60 60
Lines 4946 4946
Branches 1007 1007
=======================================
Hits 4341 4341
Misses 424 424
Partials 181 181 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @mjsqu!
Adding the expression to the jsonpath logging message can be helpful in determining whether the message refers to a "next page" jsonpath parsing call, or a "records" parsing call
📚 Documentation preview 📚: https://meltano-sdk--2118.org.readthedocs.build/en/2118/