refactor(targets): Create interface for schema validation in sinks, and implement it for python-jsonschema
#2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuzzCutNorman
requested review from
edgarrmondragon and
kgpayne
as code owners
CodSpeed Performance ReportMerging #2136 will not alter performanceComparing Summary
|
|
@edgarrmondragon when you get a chance can you give this a quick look. If you would please make sure I got the basics moved over and I didn't miss anything. I don't like the name |
BuzzCutNorman
changed the title
Co-authored-by: Edgar Ramírez Mondragón <16805946+edgarrmondragon@users.noreply.github.com>
…owing-customization
…o meltano-2136-pr-feedback
…-library-allowing-customization
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2136 +/- ##
==========================================
+ Coverage 87.89% 87.98% +0.08%
==========================================
Files 60 60
Lines 4958 5002 +44
Branches 1008 1013 +5
==========================================
+ Hits 4358 4401 +43
Misses 424 424
- Partials 176 177 +1 ☔ View full report in Codecov by Sentry. |
…-abstract-jsonschmea-library-allowing-customization
edgarrmondragon
changed the title
python-jsonschema
edgarrmondragon
approved these changes
Jan 11, 2024
edgarrmondragon
changed the title
python-jsonschemapython-jsonschema
BuzzCutNorman
deleted the
1457-abstract-jsonschmea-library-allowing-customization
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls out the JSONSchmea library abstraction work done in PR #2066 which built upon PR #1471.
This refactor will allow Target developers more control of what JSONSchema validation will be performed and also what JSONSChema library will perform the validation. Format validation is turned off by default.
Closes #1457
📚 Documentation preview 📚: https://meltano-sdk--2136.org.readthedocs.build/en/2136/