Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Reduce amount of unnecessary whitespace in Singer output #2184

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jan 26, 2024

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/reduce-whitespace-singer-output branch from 05c0002 to 96e6eb2 Compare January 26, 2024 02:55
Copy link

codspeed-hq bot commented Jan 26, 2024

CodSpeed Performance Report

Merging #2184 will not alter performance

⚠️ No base runs were found

Falling back to comparing edgarrmondragon/fix/reduce-whitespace-singer-output (96e6eb2) with main (392b1c7)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98d4375) 88.49% compared to head (96e6eb2) 88.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2184   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files          54       54           
  Lines        4711     4711           
  Branches      961      961           
=======================================
  Hits         4169     4169           
  Misses        384      384           
  Partials      158      158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 26, 2024 16:06
@edgarrmondragon edgarrmondragon merged commit b382969 into main Jan 26, 2024
32 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/fix/reduce-whitespace-singer-output branch January 26, 2024 16:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant