Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(taps): Support non-nullable but not required SQL columns #2225

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Feb 6, 2024

Closes #2224


📚 Documentation preview 📚: https://meltano-sdk--2225.org.readthedocs.build/en/2225/

Copy link

codspeed-hq bot commented Feb 6, 2024

CodSpeed Performance Report

Merging #2225 will not alter performance

Comparing edgarrmondragon/fix/support-nullable-not-required-sql-fields (1599f28) with main (b7b8d15)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b7b8d15) 88.47% compared to head (1599f28) 88.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2225   +/-   ##
=======================================
  Coverage   88.47%   88.47%           
=======================================
  Files          54       54           
  Lines        4720     4721    +1     
  Branches      919      919           
=======================================
+ Hits         4176     4177    +1     
  Misses        383      383           
  Partials      161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/support-nullable-not-required-sql-fields branch 2 times, most recently from 48111a8 to d112b22 Compare February 6, 2024 23:36
@edgarrmondragon edgarrmondragon marked this pull request as ready for review February 7, 2024 00:10
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/support-nullable-not-required-sql-fields branch from d112b22 to 90a0cf2 Compare February 7, 2024 15:58
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/support-nullable-not-required-sql-fields branch from 90a0cf2 to 1130fef Compare February 7, 2024 21:08
@edgarrmondragon edgarrmondragon merged commit 89d6afc into main Feb 9, 2024
32 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/fix/support-nullable-not-required-sql-fields branch February 9, 2024 18:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Required and non-nullable attributes of SQL columns are mixed
1 participant