Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(targets): Bumped min joblib dependency to >=1.3.0 and replaced deprecated parallel_backend with parallel_config #2288

Conversation

BuzzCutNorman
Copy link
Contributor

@BuzzCutNorman BuzzCutNorman commented Mar 7, 2024

JobLlib which is used in Target._drain_all to accomplish threaded drains of all the sinks utilizes parallel_backend which has been deprecated. The suggested replaement is parallel_config.

https://joblib.readthedocs.io/en/stable/index.html#deprecated-functionalities


📚 Documentation preview 📚: https://meltano-sdk--2288.org.readthedocs.build/en/2288/

Copy link

codspeed-hq bot commented Mar 7, 2024

CodSpeed Performance Report

Merging #2288 will not alter performance

Comparing BuzzCutNorman:chore-target-joblib-to-use-parallel-config (764b4e0) with main (aa8b5ef)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.76%. Comparing base (aa8b5ef) to head (764b4e0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2288   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files          54       54           
  Lines        4769     4769           
  Branches      928      928           
=======================================
  Hits         4233     4233           
  Misses        374      374           
  Partials      162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented Mar 7, 2024

I think this requires us to bump the min joblib constraint to >=1.3.0

https://joblib.readthedocs.io/en/stable/developing.html#release-1-3-0-2023-06-28

(I kinda want to start using uv for its --resolution=lowest-direct at some point)

@edgarrmondragon edgarrmondragon changed the title chore(target): Replace deprecated parallel_backend with parallel_config fix(targets): Bumped min joblib dependency to >=1.3.0 and replaced deprecated parallel_backend with parallel_config Mar 7, 2024
@BuzzCutNorman
Copy link
Contributor Author

I think this requires us to bump the min joblib constraint to >=1.3.0

https://joblib.readthedocs.io/en/stable/developing.html#release-1-3-0-2023-06-28

Great catch 🥳 I missed that it isn't present until 1.3.0

@BuzzCutNorman BuzzCutNorman marked this pull request as ready for review March 7, 2024 18:16
@BuzzCutNorman BuzzCutNorman requested review from a team and kgpayne as code owners March 7, 2024 18:16
@edgarrmondragon
Copy link
Collaborator

Thanks!

@edgarrmondragon edgarrmondragon added this pull request to the merge queue Mar 7, 2024
Merged via the queue into meltano:main with commit a72a987 Mar 7, 2024
30 checks passed
@BuzzCutNorman BuzzCutNorman deleted the chore-target-joblib-to-use-parallel-config branch March 7, 2024 19:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants