Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(taps): Added a default user agent for REST and GraphQL taps #2549

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 19, 2024

So we encourage taps to be good WWW citizens :)


📚 Documentation preview 📚: https://meltano-sdk--2549.org.readthedocs.build/en/2549/

Copy link

codspeed-hq bot commented Jul 19, 2024

CodSpeed Performance Report

Merging #2549 will not alter performance

Comparing edgarrmondragon/feat/default-user-agent (f9a074c) with main (477a5eb)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.51%. Comparing base (87d78b3) to head (dc7dcc7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2549      +/-   ##
==========================================
+ Coverage   89.47%   89.51%   +0.04%     
==========================================
  Files          58       58              
  Lines        4798     4799       +1     
  Branches      936      936              
==========================================
+ Hits         4293     4296       +3     
+ Misses        352      351       -1     
+ Partials      153      152       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon changed the title feat: Added a default user agent feat(taps): Added a default user agent Jul 19, 2024
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/default-user-agent branch from f432a01 to 792beb2 Compare July 30, 2024 20:30
@edgarrmondragon edgarrmondragon changed the title feat(taps): Added a default user agent feat(taps): Added a default user agent for REST and GraphQL taps Aug 5, 2024
@edgarrmondragon edgarrmondragon added this to the v0.40.0 milestone Aug 6, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 13, 2024 19:46
@edgarrmondragon edgarrmondragon merged commit be349ac into main Aug 13, 2024
34 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/feat/default-user-agent branch August 13, 2024 20:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant