Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(taps): SQL taps now emit schemas with maxLength when applicable #2651

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Sep 6, 2024

@edgarrmondragon edgarrmondragon added this to the v0.41.0 milestone Sep 6, 2024
Copy link

codspeed-hq bot commented Sep 6, 2024

CodSpeed Performance Report

Merging #2651 will not alter performance

Comparing edgarrmondragon/feat/schema-max-length (f4203c6) with main (ae86c53)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.82%. Comparing base (ae86c53) to head (f4203c6).
Report is 112 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2651      +/-   ##
==========================================
- Coverage   89.86%   89.82%   -0.04%     
==========================================
  Files          58       58              
  Lines        4884     4886       +2     
  Branches      959      960       +1     
==========================================
  Hits         4389     4389              
- Misses        344      346       +2     
  Partials      151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/schema-max-length branch from 39a0ed5 to 5e327c9 Compare September 6, 2024 18:11
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/schema-max-length branch from 5e327c9 to f4203c6 Compare September 6, 2024 18:28
@edgarrmondragon edgarrmondragon marked this pull request as ready for review September 6, 2024 18:34
@edgarrmondragon edgarrmondragon merged commit 4ce312f into main Sep 6, 2024
37 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/feat/schema-max-length branch September 6, 2024 18:34
@edgarrmondragon edgarrmondragon added the Release Highlight Call this out in the release notes label Sep 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Release Highlight Call this out in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant