Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Properties dropped using None or __NULL__ in stream maps are now also removed from the schema required array #2663

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Sep 11, 2024

Closes #2662.


📚 Documentation preview 📚: https://meltano-sdk--2663.org.readthedocs.build/en/2663/

Copy link

codspeed-hq bot commented Sep 11, 2024

CodSpeed Performance Report

Merging #2663 will not alter performance

Comparing 2662-bug-using-stream-maps-to-remove-a-property-doesnt-drop-it-from-the-json-schema-required-array (59c5f7e) with main (f465705)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (f465705) to head (59c5f7e).
Report is 113 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2663      +/-   ##
==========================================
+ Coverage   89.82%   89.86%   +0.04%     
==========================================
  Files          58       58              
  Lines        4886     4886              
  Branches      960      960              
==========================================
+ Hits         4389     4391       +2     
+ Misses        346      344       -2     
  Partials      151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon added this to the v0.41.0 milestone Sep 11, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review September 11, 2024 15:49
…rty-doesnt-drop-it-from-the-json-schema-required-array
@edgarrmondragon edgarrmondragon merged commit 6b3869d into main Sep 11, 2024
37 checks passed
@edgarrmondragon edgarrmondragon deleted the 2662-bug-using-stream-maps-to-remove-a-property-doesnt-drop-it-from-the-json-schema-required-array branch September 11, 2024 16:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Using stream maps to remove a property doesn't drop it from the JSON schema "required": [...] array
1 participant