-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
refactor: Remove non-functional record-flattening
capability
#2666
refactor: Remove non-functional record-flattening
capability
#2666
Conversation
CodSpeed Performance ReportMerging #2666 will not alter performanceComparing Summary
|
record-flatttening
capabilityrecord-flattening
capability
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2666 +/- ##
==========================================
- Coverage 89.86% 89.86% -0.01%
==========================================
Files 58 58
Lines 4886 4885 -1
Branches 960 960
==========================================
- Hits 4391 4390 -1
Misses 344 344
Partials 151 151 ☔ View full report in Codecov by Sentry. |
record-flattening
capabilityrecord-flattening
capability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to suggest going though a deprecation period but absolutely nobody is using this 😅
the griffe failure is expected cause we're removing something from a public API, ok to ignore |
I'll ready those other PRs now. 🙂 |
As per https://meltano.slack.com/archives/C06A1LKFAAC/p1725964942643019,
record-flatting
appears to be unused - all current flattening logic pertains toschema-flattening
only.Follow-on PRs:
record-flattening
capability in favour ofschema-flattening
meltano#8762record-flattening
capability in favour ofschema-flattening
hub#1839record-flattening
capability hub-utils#154📚 Documentation preview 📚: https://meltano-sdk--2666.org.readthedocs.build/en/2666/