Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: Remove non-functional record-flattening capability #2666

Merged
merged 3 commits into from
Sep 12, 2024
Merged

refactor: Remove non-functional record-flattening capability #2666

merged 3 commits into from
Sep 12, 2024

Conversation

ReubenFrankel
Copy link
Contributor

@ReubenFrankel ReubenFrankel commented Sep 12, 2024

Copy link

codspeed-hq bot commented Sep 12, 2024

CodSpeed Performance Report

Merging #2666 will not alter performance

Comparing ReubenFrankel:chore/record-flattening-unused (899e41f) with main (998083a)

Summary

✅ 6 untouched benchmarks

@ReubenFrankel ReubenFrankel changed the title chore: Remove non-functional record-flatttening capability chore: Remove non-functional record-flattening capability Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (998083a) to head (899e41f).
Report is 113 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2666      +/-   ##
==========================================
- Coverage   89.86%   89.86%   -0.01%     
==========================================
  Files          58       58              
  Lines        4886     4885       -1     
  Branches      960      960              
==========================================
- Hits         4391     4390       -1     
  Misses        344      344              
  Partials      151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon changed the title chore: Remove non-functional record-flattening capability refactor: Remove non-functional record-flattening capability Sep 12, 2024
Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to suggest going though a deprecation period but absolutely nobody is using this 😅

@edgarrmondragon
Copy link
Collaborator

the griffe failure is expected cause we're removing something from a public API, ok to ignore

@edgarrmondragon edgarrmondragon merged commit 170f5bc into meltano:main Sep 12, 2024
32 of 33 checks passed
@ReubenFrankel ReubenFrankel deleted the chore/record-flattening-unused branch September 12, 2024 16:05
@ReubenFrankel
Copy link
Contributor Author

I'll ready those other PRs now. 🙂

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants