Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: A clear error message is now emitted when flattening is enable but flattening_max_depth is not set #2683

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Sep 23, 2024

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/clear-error-message-missing-flattening-max-depth branch from 8a609f6 to 8eb341d Compare September 23, 2024 17:43
Copy link

codspeed-hq bot commented Sep 23, 2024

CodSpeed Performance Report

Merging #2683 will not alter performance

Comparing edgarrmondragon/fix/clear-error-message-missing-flattening-max-depth (f037c67) with main (3d3ac7b)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (765a378) to head (f037c67).
Report is 104 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2683   +/-   ##
=======================================
  Coverage   90.24%   90.25%           
=======================================
  Files          58       58           
  Lines        4891     4895    +4     
  Branches      963      964    +1     
=======================================
+ Hits         4414     4418    +4     
  Misses        329      329           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review September 23, 2024 18:16
@edgarrmondragon edgarrmondragon merged commit e997deb into main Sep 23, 2024
37 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/fix/clear-error-message-missing-flattening-max-depth branch September 23, 2024 18:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant