Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: All HTTP timeout exceptions are now retried in REST and GraphQL streams #2697

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Oct 2, 2024

Closes #2643


📚 Documentation preview 📚: https://meltano-sdk--2697.org.readthedocs.build/en/2697/

@edgarrmondragon edgarrmondragon linked an issue Oct 2, 2024 that may be closed by this pull request
1 task
Copy link

codspeed-hq bot commented Oct 2, 2024

CodSpeed Performance Report

Merging #2697 will not alter performance

Comparing 2643-bug-reststream-not-retrying-in-timeouterror (8121172) with main (1442536)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.50%. Comparing base (eb48cf6) to head (8121172).
Report is 97 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2697   +/-   ##
=======================================
  Coverage   90.50%   90.50%           
=======================================
  Files          62       62           
  Lines        4994     4994           
  Branches      974      974           
=======================================
  Hits         4520     4520           
  Misses        328      328           
  Partials      146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review October 2, 2024 20:39
@edgarrmondragon edgarrmondragon merged commit 743bfaf into main Oct 2, 2024
37 of 38 checks passed
@edgarrmondragon edgarrmondragon deleted the 2643-bug-reststream-not-retrying-in-timeouterror branch October 2, 2024 20:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: RESTStream not retrying in TimeoutError
1 participant