-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: Respect standard Singer stream metadata table-key-properties
, replication-key
and forced-replication-method
#2770
Merged
edgarrmondragon
merged 5 commits into
main
from
2660-bug-table-key-properties-in-metadata-extra-does-not-populate-schema-key_properties-for-tap-bigquery
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
CodSpeed Performance ReportMerging #2770 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2770 +/- ##
==========================================
+ Coverage 90.81% 90.83% +0.01%
==========================================
Files 62 62
Lines 5130 5139 +9
Branches 660 661 +1
==========================================
+ Hits 4659 4668 +9
Misses 330 330
Partials 141 141 ☔ View full report in Codecov by Sentry. |
9b7a6bf
to
ad21a68
Compare
ad21a68
to
1696cf7
Compare
…tra-does-not-populate-schema-key_properties-for-tap-bigquery
table-key-properties
, replication-key
and forced-replication-method
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
- [ ] DocumentationRelated:
table-key-properties
inmetadata
extra does not populate schemakey_properties
fortap-bigquery
#2660📚 Documentation preview 📚: https://meltano-sdk--2770.org.readthedocs.build/en/2770/