Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Respect standard Singer stream metadata table-key-properties, replication-key and forced-replication-method #2770

Conversation

Copy link

codspeed-hq bot commented Nov 20, 2024

CodSpeed Performance Report

Merging #2770 will not alter performance

Comparing 2660-bug-table-key-properties-in-metadata-extra-does-not-populate-schema-key_properties-for-tap-bigquery (a03d4e0) with main (8dcf496)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (8dcf496) to head (a03d4e0).
Report is 87 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2770      +/-   ##
==========================================
+ Coverage   90.81%   90.83%   +0.01%     
==========================================
  Files          62       62              
  Lines        5130     5139       +9     
  Branches      660      661       +1     
==========================================
+ Hits         4659     4668       +9     
  Misses        330      330              
  Partials      141      141              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the 2660-bug-table-key-properties-in-metadata-extra-does-not-populate-schema-key_properties-for-tap-bigquery branch from 9b7a6bf to ad21a68 Compare November 20, 2024 01:30
@edgarrmondragon edgarrmondragon added Needs Documentation Release Highlight Call this out in the release notes labels Nov 20, 2024
@edgarrmondragon edgarrmondragon self-assigned this Nov 20, 2024
@edgarrmondragon edgarrmondragon force-pushed the 2660-bug-table-key-properties-in-metadata-extra-does-not-populate-schema-key_properties-for-tap-bigquery branch from ad21a68 to 1696cf7 Compare November 20, 2024 02:19
@edgarrmondragon edgarrmondragon marked this pull request as ready for review November 21, 2024 00:06
@edgarrmondragon edgarrmondragon requested review from a team as code owners November 21, 2024 00:06
@edgarrmondragon edgarrmondragon changed the title fix: Respect standard Singer stream metadata for key properties, replication key and replication method fix: Respect standard Singer stream metadata table-key-properties, replication-key and forced-replication-method Nov 21, 2024
@edgarrmondragon edgarrmondragon added this to the v0.43 milestone Nov 21, 2024
@edgarrmondragon edgarrmondragon merged commit a030c80 into main Nov 21, 2024
36 checks passed
@edgarrmondragon edgarrmondragon deleted the 2660-bug-table-key-properties-in-metadata-extra-does-not-populate-schema-key_properties-for-tap-bigquery branch November 21, 2024 00:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Needs Documentation Release Highlight Call this out in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: table-key-properties in metadata extra does not populate schema key_properties for tap-bigquery
1 participant