Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Accept a maxLength limit for VARCHARs #2774

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Nov 26, 2024

@edgarrmondragon edgarrmondragon requested a review from a team as a code owner November 26, 2024 19:10
@edgarrmondragon edgarrmondragon self-assigned this Nov 26, 2024
@edgarrmondragon edgarrmondragon added the kind/Feature New feature or request label Nov 26, 2024
@edgarrmondragon edgarrmondragon added this to the v0.43 milestone Nov 26, 2024
Copy link

codspeed-hq bot commented Nov 26, 2024

CodSpeed Performance Report

Merging #2774 will not alter performance

Comparing 1812-feat-define-a-maxlength-limit-for-varchar-at-the-connector-level (11aa295) with main (a030c80)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.84%. Comparing base (a030c80) to head (11aa295).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2774   +/-   ##
=======================================
  Coverage   90.83%   90.84%           
=======================================
  Files          62       62           
  Lines        5139     5143    +4     
  Branches      661      662    +1     
=======================================
+ Hits         4668     4672    +4     
  Misses        330      330           
  Partials      141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon merged commit 8c7c307 into main Nov 26, 2024
37 checks passed
@edgarrmondragon edgarrmondragon deleted the 1812-feat-define-a-maxlength-limit-for-varchar-at-the-connector-level branch November 26, 2024 20:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: define a maxLength limit for varchar at the connector level
1 participant