Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix: Setting stream map property to null does not remove it from SCHEMA message - [merged] #660

Closed
MeltyBot opened this issue May 4, 2022 · 0 comments
Closed

Fix: Setting stream map property to null does not remove it from SCHEMA message - [merged] #660

MeltyBot opened this issue May 4, 2022 · 0 comments
Assignees
@edgarrmondragon
Labels
gitlab merge request

Comments

@MeltyBot
Copy link
Contributor

MeltyBot commented May 4, 2022 •
edited
Loading

Merges 370-stream-map-null-remove-from-schema -> main

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/merge_requests/286

Closes #370

Thanks to TDD and checking the schema properties matches the record properties, I found another bug where flattened schemas using CustomStreamMap missed the flattening part. Added that in as well and made sure all mapper tests are passing.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@edgarrmondragon edgarrmondragon

Labels
gitlab merge request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edgarrmondragon @MeltyBot