Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Channel open errors not being handled #37

Open
quii opened this issue Jun 27, 2017 · 0 comments
Open

Channel open errors not being handled #37

quii opened this issue Jun 27, 2017 · 0 comments
Labels

Comments

@quii
Copy link
Contributor

quii commented Jun 27, 2017

c.logger.Error(fmt.Sprintf(`failed to open a new channel for "%s"`, c.channelDescription), err)

We are seeing logs like [failed to open a new channel for \"live-profile-matching-with-matches-for-notification-assembler-go-retry-10000ms-later\" Exception (504) Reason: \"channel/connection is not open\"]",

The code in the link will ultimately return a chan amqp.Channel that will never get any items in it. This will result in the service being unable to pub/sub

Also, the abstractions around this area feel a bit complicated, we should try and simplify this

@quii quii added the bug label Jun 27, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant