Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cant download any of the faa/fna/ffn/gbk file from the genome page when --docker is used #15

Closed
TKlamydionaut opened this issue Jun 26, 2023 · 5 comments · Fixed by #16

Comments

@TKlamydionaut
Copy link
Contributor

TKlamydionaut commented Jun 26, 2023

Seems like the part that binds the results and assets folders together does not happen.
bind_path_results+=("${dir}/zdb/results/blast_DB/${run_name}":"${zdb_folder}/assets/blast_DB/${run_name}")

Also, the path for the gbk file download should be RunName/gbk/filtered instead of just RunName/gbk

@bkm
Copy link
Contributor

bkm commented Jul 4, 2023

Hello (Thomas, I guess?),

Does the blast interface work in dockers ?
I'll check into the genome files download.

Thanks for bringing this up.
Bastian

@TKlamydionaut
Copy link
Contributor Author

TKlamydionaut commented Jul 4, 2023 via email

@tpillone
Copy link
Contributor

tpillone commented Jul 4, 2023

Hello,
Some files from the asset folder cannot be accessed when using docker because they are symlinks to the work directory (e.g faa and fna from the "genome" page). Blast indexes are not symblinks and can be accessed without problems.
We could fix this by simply moving files to the result folder instead of making symlinks.

@bkm bkm linked a pull request Jul 10, 2023 that will close this issue
@bkm
Copy link
Contributor

bkm commented Jul 10, 2023

This should fix it. @tpillone could you take a look at the PR ? If it's alright, I'll create a conda package tonight.

@tpillone
Copy link
Contributor

It looks good!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants