-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore(setup): rewrite packaging #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuehaiPan
force-pushed
the
setup
branch
3 times, most recently
from
July 7, 2022 14:50
8d7f7d2
to
8e5d9a8
Compare
- name: mypy | ||
run: | | ||
make mypy | ||
|
||
# - name: docstyle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you got time, maybe add the docstyle? (docsting is a mess right now I think)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may open a separate PR for this.
XuehaiPan
force-pushed
the
setup
branch
4 times, most recently
from
July 8, 2022 03:42
e137e3d
to
d1c83b8
Compare
XuehaiPan
force-pushed
the
setup
branch
4 times, most recently
from
July 8, 2022 07:15
e4fd724
to
82a3a66
Compare
XuehaiPan
force-pushed
the
setup
branch
8 times, most recently
from
July 10, 2022 07:16
fc1c898
to
dfebe80
Compare
JieRen98
approved these changes
Jul 10, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewrite packaging
setup.py
and remove functiondownload_shared_lib
. We don't need to download the.so
files from an arbitrary server because they are included in the wheels (.whl
).pybind11
and use the PyPI packagepybind11
instead. (Required bysdist
).Now we can build from source by (requires
nvcc
):Update GitHub Action workflows.
pip3 install -e .
)Misc: reformating files, docs update, and fixing requirements.