Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(accelerated_op): use correct Python Ctype for pybind11 function prototype #52

Merged
merged 4 commits into from
Aug 7, 2022

Conversation

XuehaiPan
Copy link
Member

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Use double for Python type float and int64_t for Python type int.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • New environment (non-breaking change which adds 3rd-party environment)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the code using make lint (required)
  • I have ensured make test pass. (required)

@XuehaiPan XuehaiPan force-pushed the pytype branch 8 times, most recently from b7d8d05 to d3bd3a1 Compare August 7, 2022 17:26
@XuehaiPan XuehaiPan changed the title chore(accelerated_op): use corret Python Ctype for pybind11 function prototype chore(accelerated_op): use correct Python Ctype for pybind11 function prototype Aug 7, 2022
@XuehaiPan XuehaiPan merged commit 84d1c3d into metaopt:main Aug 7, 2022
@XuehaiPan XuehaiPan deleted the pytype branch August 7, 2022 17:45
@XuehaiPan XuehaiPan added the enhancement New feature or request label Aug 8, 2022
@XuehaiPan XuehaiPan added the cxx / cuda Something related to the CXX / CUDA extension label Aug 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cxx / cuda Something related to the CXX / CUDA extension enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant