Merge pull request #83 from jankapunkt/feature-test-coverage

Implement tests + coverage

Author: Nathaniel Dsouza

.babelrc

@@ -1,3 +1,4 @@
 {
-  "presets": ["react-native"]
+  "presets": ["module:metro-react-native-babel-preset"],
+  "plugins": ["istanbul"]
 }

.gitignore

@@ -11,6 +11,7 @@ pids
 lib-cov
 
 # Coverage directory used by tools like istanbul
+.nyc_output
 coverage
 
 # Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
@@ -29,3 +30,4 @@ node_modules
 .vscode
 .idea
 .DS_Store
+

.mocharc.js

@@ -0,0 +1,14 @@
+// transpile all es6+ code in this project (but not node_modules)
+const babelRegister = require('@babel/register');
+babelRegister();
+
+// for more options see here https://github.com/mochajs/mocha/blob/master/example/config/.mocharc.yml
+module.exports = {
+  recursive: true,
+  reporter: "spec",
+  retries: 0,
+  slow: 20,
+  timeout: 2000,
+  ui: "bdd",
+  require: ['test/hooks/mockServer.js']
+}

.npmignore

@@ -1,3 +1,5 @@
 examples
 .github
-companion-packages
+companion-packages
+.nyc_output
+coverage

.nycrc.json

@@ -0,0 +1,3 @@
+{
+    "extends": "@istanbuljs/nyc-config-babel"
+}

.prettierignore

@@ -1,2 +1,5 @@
 package.json
 example/
+.nyc_output
+coverage
+node_modules

helpers/reactNativeBindings.js

@@ -0,0 +1,24 @@
+const bindings = {}
+
+// TODO:
+// we should consider implementing an injection-based pattern for
+// unstable_batchedUpdates and runAfterInteractions simply because
+// - this allows a much easier test-setup, where we don't need to mock modules
+// - we can be independent of any folder structure or refactoring
+//   that happens in react-native
+// - we can provide a default behaviour out-of-the box that gets overwritten
+//   when devs inject their favourable behaviour
+
+try {
+  require.resolve('react-native')
+  bindings.batchedUpdates = require('react-native/Libraries/Renderer/shims/ReactNative').unstable_batchedUpdates;
+  bindings.runAfterInteractions = require('react-native').InteractionManager.runAfterInteractions;
+} catch (e) {
+  // if the module is not installed (for example when running tests)
+  // we fall back to some defaults that seem to be close to what
+  // the original functions implement
+  bindings.batchedUpdates = cb => cb()
+  bindings.runAfterInteractions = fn => setTimeout(() => fn(), 50)
+}
+
+module.exports = bindings

lib/mongo-id.js

@@ -3,11 +3,13 @@ import EJSON from 'ejson';
 
 const MongoID = {};
 
-MongoID._looksLikeObjectID = function(str) {
-  return str.length === 24 && str.match(/^[0-9a-f]*$/);
+const objectIdRegex = /^[0-9a-f]*$/
+
+MongoID._looksLikeObjectID = function _looksLikeObjectID(str) {
+  return str.length === 24 && objectIdRegex.test(str);
 };
 
-MongoID.ObjectID = function(hexString) {
+MongoID.ObjectID = function ObjectID(hexString) {
   //random-based impl of Mongo ObjectID
   var self = this;
   if (hexString) {
@@ -18,32 +20,33 @@ MongoID.ObjectID = function(hexString) {
     // meant to work with _.isEqual(), which relies on structural equality
     self._str = hexString;
   } else {
-    self._str = Random.hexString(24);
+    // self._str = Random.hexString(24);
+    throw new Error('Random.hexString not implemented, please pass a hexString');
   }
 };
 
-MongoID.ObjectID.prototype.toString = function() {
+MongoID.ObjectID.prototype.toString = function toString() {
   var self = this;
   return 'ObjectID("' + self._str + '")';
 };
 
-MongoID.ObjectID.prototype.equals = function(other) {
+MongoID.ObjectID.prototype.equals = function equals(other) {
   var self = this;
   return (
     other instanceof MongoID.ObjectID && self.valueOf() === other.valueOf()
   );
 };
 
-MongoID.ObjectID.prototype.clone = function() {
+MongoID.ObjectID.prototype.clone = function clone() {
   var self = this;
   return new MongoID.ObjectID(self._str);
 };
 
-MongoID.ObjectID.prototype.typeName = function() {
+MongoID.ObjectID.prototype.typeName = function typeName() {
   return 'oid';
 };
 
-MongoID.ObjectID.prototype.getTimestamp = function() {
+MongoID.ObjectID.prototype.getTimestamp = function getTimestamp() {
   var self = this;
   return parseInt(self._str.substr(0, 8), 16);
 };
@@ -56,7 +59,7 @@ EJSON.addType('oid', function(str) {
   return new MongoID.ObjectID(str);
 });
 
-MongoID.idStringify = function(id) {
+MongoID.idStringify = function idStringify(id) {
   if (id instanceof MongoID.ObjectID) {
     return id.valueOf();
   } else if (typeof id === 'string') {
@@ -85,7 +88,7 @@ MongoID.idStringify = function(id) {
   }
 };
 
-MongoID.idParse = function(id) {
+MongoID.idParse = function idParse(id) {
   if (id === '') {
     return id;
   } else if (id === '-') {
@@ -100,3 +103,5 @@ MongoID.idParse = function(id) {
     return id;
   }
 };
+
+module.exports = MongoID;

lib/socket.js

@@ -1,4 +1,5 @@
 import EventEmitter from 'wolfy87-eventemitter';
+// TODO: 0.60+ supports import { EventEmitter } from 'events';
 import EJSON from 'ejson';
 import './mongo-id'; //  Register mongo object ids */
 

lib/utils.js

@@ -6,6 +6,9 @@ export function uniqueId() {
   return (i++).toString();
 }
 
+// XXX: we should extract this function and let clients inject
+// it, so they can leverage react-native crypto packages that
+// implement a secure hashing algorithm like bcrypt
 export function hashPassword(password) {
   return {
     digest: SHA256(password).toString(), // lgtm [js/insufficient-password-hash]
@@ -78,8 +81,7 @@ export function isPlainObject(obj) {
 
   // Own properties are enumerated firstly, so to speed up,
   // if last one is own, then all properties are own.
-  for (key in obj) {
-  }
+  for (key in obj) {}
 
   return key === undefined || hasOwn.call(obj, key);
 }