We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Describe the bug
_startLoggingIn() { this._reactiveDict.set('_loggingIn', true); Data.notify('loggingIn'); }, _startLoggingOut() { User._isLoggingOut = true; Data.notify('loggingOut'); }, _endLoggingIn() { this._reactiveDict.set('_loggingIn', false); Data.notify('loggingIn'); }, _endLoggingOut() { User._isLoggingOut = false; Data.notify('loggingOut'); },
it's not determinable, at which method the even has fired as they are clearly the same.
Expected behavior It should be distinguishable at which function the events fired. Proposed change would be to use clear naming:
_startLoggingIn() { this._reactiveDict.set('_loggingIn', true); Data.notify('loggingIn'); }, _startLoggingOut() { User._isLoggingOut = true; Data.notify('loggingOut'); }, _endLoggingIn() { this._reactiveDict.set('_loggingIn', false); Data.notify('loggedIn'); }, _endLoggingOut() { User._isLoggingOut = false; Data.notify('loggedOut') },
The text was updated successfully, but these errors were encountered:
Closing this issue due to no activity. Feel free to reopen.
Sorry, something went wrong.
No branches or pull requests
Describe the bug
it's not determinable, at which method the even has fired as they are clearly the same.
Expected behavior
It should be distinguishable at which function the events fired. Proposed change would be to use clear naming:
The text was updated successfully, but these errors were encountered: