Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes nested reasons being overwritten by outer spec's reason #171. #267

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

Sardtok
Copy link
Contributor

@Sardtok Sardtok commented May 11, 2022

This should fix #171, where a reason set on an outer spec overwrites the inner problem's reason.

@codecov-commenter
Copy link

Codecov Report

Merging #267 (ae28029) into master (8a3284f) will not change coverage.
Report is 9 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #267   +/-   ##
=======================================
  Coverage   88.01%   88.01%           
=======================================
  Files          16       16           
  Lines        2052     2052           
  Branches      183      183           
=======================================
  Hits         1806     1806           
  Misses         63       63           
  Partials      183      183           
Files Changed Coverage Δ
src/spec_tools/core.cljc 94.42% <100.00%> (ø)

... and 1 file with indirect coverage changes

@Sardtok
Copy link
Contributor Author

Sardtok commented Jan 24, 2024

@ikitommi Have you had a look at this?

@Sardtok
Copy link
Contributor Author

Sardtok commented Jun 27, 2024

Has anyone had an opportunity to look at the PR? If there are any reasons, like lack of regression tests, that block merging it, I'd be happy to update it.

@ikitommi
Copy link
Member

Thanks for the fix, I'll merge and add a test.

@ikitommi ikitommi merged commit ec02b0a into metosin:master Jun 29, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

:reason doesn't compose as expected
3 participants