metrics-util: fix soundness issue with AtomicBucket<T>

tobz · tobz · commit 8e6daabbc6fb · 2021-04-07T21:48:06.000-04:00
diff --git a/metrics-util/src/bucket.rs b/metrics-util/src/bucket.rs
@@ -96,8 +96,8 @@ impl<T> Block<T> {
     }
 }
 
-unsafe impl<T> Send for Block<T> {}
-unsafe impl<T> Sync for Block<T> {}
+unsafe impl<T: Send> Send for Block<T> {}
+unsafe impl<T: Sync> Sync for Block<T> {}
 
 impl<T> std::fmt::Debug for Block<T> {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {

Original file line number	Diff line number	Diff line change
`@@ -96,8 +96,8 @@ impl<T> Block<T> {`
`96`	`96`	`}`
`97`	`97`	`}`
`98`	`98`
`99`		`-unsafe impl<T> Send for Block<T> {}`
`100`		`-unsafe impl<T> Sync for Block<T> {}`
	`99`	`+unsafe impl<T: Send> Send for Block<T> {}`
	`100`	`+unsafe impl<T: Sync> Sync for Block<T> {}`
`101`	`101`
`102`	`102`	`impl<T> std::fmt::Debug for Block<T> {`
`103`	`103`	`fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {`