Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove underscore from display name of timezone #37

Conversation

jameschristopher
Copy link

@jameschristopher jameschristopher commented Apr 11, 2017

fixes this issue #32

The simple solution would be to do the underscore removing operation in your app's models.py and then feed underscore-less choices into the field with the choices arg.

Not sure if this is a big enough issue to warrant a PR. If so how do you want to proceed with tests. Thoughts?

@mfogel mfogel self-requested a review February 28, 2018 22:12
@mfogel mfogel added this to the 3.0 milestone Mar 1, 2018
@mfogel
Copy link
Owner

mfogel commented Mar 1, 2018

Thanks for the PR. Agreed, human-readable display of these timezones shouldn't include underscores.

I'm going to put off merging this untill the next major version as this could be considered a backward-incompatible change. I'm planning to release a new minor version (2.1) in the next few days, let that bake for a week or two, and then release a new major version (3.0)

mfogel added a commit that referenced this pull request Apr 19, 2018
@mfogel
Copy link
Owner

mfogel commented Apr 19, 2018

I decided on just removing underscores from the human-readable portion of the default choices. I don't want to make it so that a package using this field can't specify human-readable choices with underscores. Rather, I think it's better to just change the default.

As such, I merged in one of your two commits but not the other. Thanks for your contribution!

@mfogel mfogel closed this Apr 19, 2018
@jameschristopher
Copy link
Author

jameschristopher commented Apr 19, 2018

Great! Thanks for maintaining this repository!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants