-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Corruption and crashes when using IP options #288
Comments
Ugh this sucks, sorry. I know what the issue is, I'll fix it tomorrow and I'll run this with randomized inputs to make sure it doesn't blow up. Thanks for the report! |
Just pushed a fix to |
That was quick, thanks! |
Could we get a new release including this fix? |
That's probably a good idea, I'll try to release this tonight. |
Just pushed the new tag |
Thanks for the fast reply. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
When handling pcap files which contain IP packets with options, libtins either crashes (observed when using EOL or NOP) or corrupts the packet. In the minimal example provided here, libtins overwrites the first byte of the contained UDP-header with a zero, changing the port-number.
I observed this behavior on Arch Linux with libtins 4.0. Version 3.4 on Ubuntu 17.10 seems to be fine instead.
The text was updated successfully, but these errors were encountered: