Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[bug] UDP::matches_response() return 0 when no inner PDU is available #521

Open
markvmk opened this issue Dec 14, 2023 · 0 comments
Open

Comments

@markvmk
Copy link

markvmk commented Dec 14, 2023

Hi,

When trying to match against UDP response that has no payload the UDP::matches_response() fails (returns false).
https://github.com/mfontanini/libtins/blob/master/src/udp.cpp#L173

For EthernetII and IP PDUs the implementation of matches_response() returns true in case no inner PDU is present.
I am not sure if the UDP implementation is intentionally done like that but as I could not find this in the documentation I assume that this is a bug and UDP::matches_response() should also return true when inner PDU is not present.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant