Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

wrong "enum OptionTypes" definition #532

Open
loop333 opened this issue May 9, 2024 · 2 comments
Open

wrong "enum OptionTypes" definition #532

loop333 opened this issue May 9, 2024 · 2 comments

Comments

@loop333
Copy link

loop333 commented May 9, 2024

WAKEUP_SCHEDULE,

    WAKEUP_SCHEDULE,
    CH_SWITCH_TIMING,

https://github.com/wireshark/wireshark/blob/00e069e6cd9d72e79f207bbb5ddc6901c6e14420/epan/dissectors/packet-ieee80211.h#L454

   #define TAG_WAKEUP_SCHEDULE          102  /* IEEE Std 802.11z-2010 */
   #define TAG_CHANNEL_SWITCH_TIMING    104  /* IEEE Std 802.11z-2010 */

so CH_SWITCH_TIMING gets 103 instead of 104
to fix:
WAKEUP_SCHEDULE,
CH_SWITCH_TIMING = 104,

@loop333
Copy link
Author

loop333 commented May 11, 2024

also missed:
#define TAG_ERP_INFO_OLD 47 /* IEEE Std 802.11g/D4.0 /
#define TAG_ELEMENT_ID_EXTENSION 255 /
IEEE Std 802.11ai */

@jamestiotio
Copy link
Contributor

jamestiotio commented Jun 14, 2024

There are also many missing options from the newer IEEE 802.11 standard revisions/amendments (such as 802.11ah and 802.11ai). It seems that the OptionTypes enum is due for an update.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants