Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unimplemented interface members #542

Closed
tomcrane opened this issue Jan 2, 2025 · 2 comments
Closed

Unimplemented interface members #542

tomcrane opened this issue Jan 2, 2025 · 2 comments

Comments

@tomcrane
Copy link

tomcrane commented Jan 2, 2025

Hi, not sure it this is an issue with the source schema but the following two XSDs produce some invalid code when the --interface option is left at its default enabled setting:

xscgen -p DigitalPreservation.XmlGen --nullable --netCore https://www.loc.gov/standards/mets/mets.xsd
xscgen -p DigitalPreservation.XmlGen --nullable --netCore https://www.loc.gov/standards/mods/v3/mods-3-8.xsd

e.g.,

DigitalPreservation.XmlGen.Mods.V3.cs(1655, 47): [CS0535] 'LanguageDefinition' does not implement interface member 'ILanguageAttributeGroup.Lang'

(and more similar)

(METS and MODS are Library of Congress standards used in digital preservation)

With the interface option disabled, the code is valid:

xscgen -p DigitalPreservation.XmlGen --nullable --netCore --interface- https://www.loc.gov/standards/mets/mets.xsd
xscgen -p DigitalPreservation.XmlGen --nullable --netCore --interface- https://www.loc.gov/standards/mods/v3/mods-3-8.xsd

I wasn't sure how deep to go into the code before raising the issue, in case it's something obvious - but happy to help.

@mganss
Copy link
Owner

mganss commented Jan 3, 2025

Can you share the XSD files?

@tomcrane
Copy link
Author

tomcrane commented Jan 6, 2025

I ran them directly against the live published xsd, so:

https://www.loc.gov/standards/mets/mets.xsd
https://www.loc.gov/standards/mods/v3/mods-3-8.xsd

@mganss mganss closed this as completed in 70f49d8 Feb 2, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants