deep-exit: fix mixed receiver type (lintDeepExit) (#1150)

denisvmedia · web-flow · commit 3bc240434f44 · 2024-11-30T10:06:59.000+01:00
diff --git a/rule/deep_exit.go b/rule/deep_exit.go
@@ -17,7 +17,7 @@ func (*DeepExitRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 		failures = append(failures, failure)
 	}
 
-	w := lintDeepExit{onFailure: onFailure, isTestFile: file.IsTest()}
+	w := &lintDeepExit{onFailure: onFailure, isTestFile: file.IsTest()}
 	ast.Walk(w, file.AST)
 	return failures
 }
@@ -32,7 +32,7 @@ type lintDeepExit struct {
 	isTestFile bool
 }
 
-func (w lintDeepExit) Visit(node ast.Node) ast.Visitor {
+func (w *lintDeepExit) Visit(node ast.Node) ast.Visitor {
 	if fd, ok := node.(*ast.FuncDecl); ok {
 		if w.mustIgnore(fd) {
 			return nil // skip analysis of this function

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ func (DeepExitRule) Apply(file lint.File, _ lint.Arguments) []lint.Failure {`
`17`	`17`	`failures = append(failures, failure)`
`18`	`18`	`}`
`19`	`19`
`20`		`- w := lintDeepExit{onFailure: onFailure, isTestFile: file.IsTest()}`
	`20`	`+ w := &lintDeepExit{onFailure: onFailure, isTestFile: file.IsTest()}`
`21`	`21`	`ast.Walk(w, file.AST)`
`22`	`22`	`return failures`
`23`	`23`	`}`
`@@ -32,7 +32,7 @@ type lintDeepExit struct {`
`32`	`32`	`isTestFile bool`
`33`	`33`	`}`
`34`	`34`
`35`		`-func (w lintDeepExit) Visit(node ast.Node) ast.Visitor {`
	`35`	`+func (w *lintDeepExit) Visit(node ast.Node) ast.Visitor {`
`36`	`36`	`if fd, ok := node.(*ast.FuncDecl); ok {`
`37`	`37`	`if w.mustIgnore(fd) {`
`38`	`38`	`return nil // skip analysis of this function`