Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ci] Decrease build times #1528

Closed
ofek opened this issue May 24, 2020 · 4 comments · Fixed by #2212
Closed

[ci] Decrease build times #1528

ofek opened this issue May 24, 2020 · 4 comments · Fixed by #2212

Comments

@ofek
Copy link
Contributor

ofek commented May 24, 2020

(Opening this while it's in my mind)

While overall build times are faster than before, individual jobs take a bit longer than on AppVeyor

From

pywin32/setup.py

Lines 22 to 24 in 5f47dc1

At a minimum, you must have the same version of Microsoft Visual C++ that is
used for the Python version you are building, plus the Windows 8.1 SDK. Note
that the Windows 8.1 SDK is often bundled with Microsoft Visual C++.
Windows 8.1 SDK is a hard dependency

It didn't seem available on GitHub Actions runner https://help.github.com/en/actions/reference/software-installed-on-github-hosted-runners as setup.py failed

So we spend multiple minutes installing it from Chocolatey

- name: Install Windows 8.1 SDK
run: choco install windows-sdk-8.1

Options:

  • Drop 8.1?
  • Maybe it's actually on runner & a .bat script somewhere needs to be executed?
  • Faster way to install it?
@ofek
Copy link
Contributor Author

ofek commented May 24, 2020

Hmm, found actions/runner-images#842

The Windows 8.1 SDK is no longer available in the Visual Studio installer. Please upgrade your C++ projects to the latest Windows 10 SDK. If you have a hard dependency on 8.1, you can download it from the Windows SDK archive.

considering that it can be installed on runtime and it's a pretty old version, we won't install it by default in the images

@mhammond
Copy link
Owner

Dropping 8.1 sounds fine to me - the problems solved by insisting on that probably went away when earlier 2.x were dropped. It might make sense to tackle this after I drop 2.7 support though.

@ofek
Copy link
Contributor Author

ofek commented Oct 31, 2020

Did we drop 8.1 yet?

@mhammond
Copy link
Owner

mhammond commented Nov 2, 2020

yep

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants