Merge pull request #9 from mhart/fix-buffer-constructor-vuln

mhart · web-flow · commit 2f4a9d496f94 · 2018-05-17T20:22:09.000+10:00
Ensure data is not a number in Buffer constructor
diff --git a/stringstream.js b/stringstream.js
@@ -28,7 +28,7 @@ StringStream.prototype.write = function(data) {
     return false
   }
   if (this.fromEncoding) {
-    if (Buffer.isBuffer(data)) data = data.toString()
+    if (Buffer.isBuffer(data) || typeof data === 'number') data = data.toString()
     data = new Buffer(data, this.fromEncoding)
   }
   var string = this.decoder.write(data)

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ StringStream.prototype.write = function(data) {`
`28`	`28`	`return false`
`29`	`29`	`}`
`30`	`30`	`if (this.fromEncoding) {`
`31`		`- if (Buffer.isBuffer(data)) data = data.toString()`
	`31`	`+ if (Buffer.isBuffer(data) \|\| typeof data === 'number') data = data.toString()`
`32`	`32`	`data = new Buffer(data, this.fromEncoding)`
`33`	`33`	`}`
`34`	`34`	`var string = this.decoder.write(data)`