Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement a 'remote_host' matcher #278

Open
cohesive-flight opened this issue Dec 28, 2024 · 3 comments
Open

Implement a 'remote_host' matcher #278

cohesive-flight opened this issue Dec 28, 2024 · 3 comments

Comments

@cohesive-flight
Copy link

I would like to see this module include a 'remote_host' matcher, similar to the one in the caddy-remote-host module. I'm running this within docker, so it'd be preferable to refer to the containers based on their names instead of their IPs.

Please also consider adding an option to include the hostname in the debug logs rather than just the IP.

@mholt
Copy link
Owner

mholt commented Dec 29, 2024

The problem with that is it requires expensive DNS lookups in a hot path.

@cohesive-flight
Copy link
Author

cohesive-flight commented Dec 29, 2024

I suggest adding a disclaimer for the matcher then. It would make it up to the user if they're willing to take a performance hit for the convenience it'd provide. And in docker's case, since the records are defined in an internal DNS server, it should help minimize its impact.

@mholt
Copy link
Owner

mholt commented Dec 30, 2024

That may be fine; PRs welcome.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants