Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Should check crc32s against the entry data #29

Open
davidmurdoch opened this issue Apr 22, 2020 · 0 comments
Open

Should check crc32s against the entry data #29

davidmurdoch opened this issue Apr 22, 2020 · 0 comments

Comments

@davidmurdoch
Copy link

I found this // TODO in the source:

unzip-stream/lib/unzip-stream.js

Line 455 in adb329b

// TODO: should be checking this against our path buffer

There are also many other uses of crc32 that could probably use an integrity check as well.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidmurdoch