refactored the naming to be more clear

Author: michael-hardeman

har-extractor/har-extract.js

@@ -3,7 +3,7 @@ const path = require ('path');
 
 const DEFAULT_OPTIONS = {
   keepOptions: false,
-  stripPII: false,
+  stripPrivateInfo: true,
   input: 'dlive.tv.har', 
   url: 'https://graphigo.prd.dlive.tv/',
   output: 'extracted.dlive.tv.har'
@@ -24,8 +24,8 @@ function maybeExtractOptionalArguments (options) {
   let nextArg;
   while ((nextArg = process.argv.shift ())) {
     switch (nextArg) {
-      case '-k': options.keepOptions = true; break;
-      case '-s': options.stripPII = false; break;
+      case '-k': options.keepOptions      = true; break;
+      case '-s': options.stripPrivateInfo = false; break;
       case '-i': required ('input',  (options.input  = process.argv.shift ())); break;
       case '-o': required ('output', (options.output = process.argv.shift ())); break;
       case '-u': required ('url',    (options.url    = process.argv.shift ())); break;
@@ -55,8 +55,8 @@ function processArguments() {
       `Usage: ${selfDetails.cmd} ${selfDetails.file} [options]\n\n` +
       '  -k        keep OPTIONS requests.\n' +
       `            default: ${DEFAULT_OPTIONS.keepOptions}\n` +
-      '  -s        strip personally identifiable information.\n' +
-      `            default: ${DEFAULT_OPTIONS.stripPII}\n` +
+      '  -s        strip private info (username, password, tokens).\n' +
+      `            default: ${DEFAULT_OPTIONS.stripPrivateInfo}\n` +
       '  -i input  the path to the .har you want to parse.\n' +
       `            default: ${DEFAULT_OPTIONS.input}\n` +
       '  -o output the path to what output file you want.\n' +
@@ -105,8 +105,8 @@ function filterOutIrrelevantLogEntries(harObject, options) {
   });
 }
 
-function shouldStripPIIFromEntries(harObject, options) {
-  if (!options.stripPII) { return; }
+function maybeStripPrivateInfoFromEntries(harObject, options) {
+  if (!options.stripPrivateInfo) { return; }
   harObject.log.entries = harObject.log.entries.map ((item) => {
 
     // TODO: determine which requests contain PII
@@ -128,7 +128,7 @@ fs.readFile (options.input, 'utf8', (err, data) => {
   let harObject = JSON.parse (data);
 
   filterOutIrrelevantLogEntries(harObject, options);
-  shouldStripPIIFromEntries(harObject, options);
+  maybeStripPrivateInfoFromEntries(harObject, options);
 
   writeOrCreateTextFile (options.output, JSON.stringify(harObject, null, 2), (err) => {
     if (err) throw err;