Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

When I set a pagination ID returns Syntax Error: Token '__currentPage' is an unexpected token at column 4 of the expression [184__currentPage] starting at [__currentPage]. #319

Closed
laudess opened this issue Mar 18, 2016 · 5 comments
Assignees
Labels

Comments

@laudess
Copy link

laudess commented Mar 18, 2016

Hello, I am working on a page with different bootstrap tabs. Each tab has it's own pagination so I need to have one dir-paginate for each tab. I have dir-paginate inside a ng-repeat, but when It comes to define the pagination-id it throws me this error:
Syntax Error: Token '__currentPage' is an unexpected token at column 4 of the expression [184__currentPage] starting at [__currentPage].

This is my code:

`



`

Thank you

@sdvcrx
Copy link

sdvcrx commented Mar 24, 2016

Same issue here. Two tabs + same template + two controller. Version 0.10.1 is working good.
=> #313

@michaelbromley
Copy link
Owner

Hi,
In v0.11.0 I introduced a change that fixes a fairly serious memory leak. It looks like it was too aggressive in the way it cleans up references and there are a couple of issues now - this included - where things break when the pagination is inside a directive that dynamically destroys DOM (e.g. ngIf, ngRepeat)

For now, just use 0.10.1 - unless you need template strings (also introduced in 0.11.0), you are not missing out on anything new. I will fix this as soon as I get some time to invest.

@michaelbromley michaelbromley self-assigned this Mar 24, 2016
@michaelbromley
Copy link
Owner

@laudess @banbanchs If you have time, could someone try to reproduce the issue by forking this plunker demo - it is using the latest version (0.11.0 right now) so hopefully you should be able to reproduce. This will greatly help me resolve the issue.

@michaelbromley
Copy link
Owner

Please update to v0.11.1 (I reverted the memory-leak fix) and let me know if this solves this issue.

@sdvcrx
Copy link

sdvcrx commented Apr 1, 2016

@michaelbromley issue solved!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants