Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[bug] Insecure TLS Skipping in Email Verification Process #709

Open
nyxfqq opened this issue Jul 8, 2024 · 0 comments
Open

[bug] Insecure TLS Skipping in Email Verification Process #709

nyxfqq opened this issue Jul 8, 2024 · 0 comments

Comments

@nyxfqq
Copy link

nyxfqq commented Jul 8, 2024

Description of the bug

In the current implementation of the ShareProofVerifier function within share.go found at github.com/m/mickael-kerjean/filestash/server/model, the TLS verification is being bypassed when sending out email verification codes. This practice is explicitly warned against in the gomail package documentation, stating that it is insecure and should not be used in a production environment.

Step by step instructions to reproduce the bug

  1. Clone the repository from mickael-kerjean/filestash.
  2. Navigate to the server/model/share.go file.
  3. Locate the ShareProofVerifier function.
  4. Observe the TLS configuration for the SMTP dialer. It is configured to skip TLS verification (InsecureSkipVerify = true).
  5. Build and run the application to see that emails are sent without verifying the TLS certificate of the SMTP server.

Expected behavior

TLS verification should be enabled to ensure that all email communications are securely transmitted. This involves configuring the SMTP dialer to validate the TLS certificate of the SMTP server, ensuring that the email data remains confidential and protected during transmission.

As noted in the GoMail_documentation, skipping TLS verification is considered insecure and should never be implemented in a production environment. Doing so renders the email transmission vulnerable to man-in-the-middle attacks and exposes sensitive data to potential interception.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant