Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use gorilla mux as router #34

Closed
marcotroisi opened this issue Mar 21, 2017 · 3 comments
Closed

Use gorilla mux as router #34

marcotroisi opened this issue Mar 21, 2017 · 3 comments
Assignees

Comments

@marcotroisi
Copy link
Contributor

It appears that with the default router we're currently using, we're not able to set up regex-based endpoints, allowing us to do things like GET /users/{id}.

We need to integrate the gorilla-toolkit mux and use it for our go-kit endpoints.

@marcotroisi marcotroisi self-assigned this Mar 21, 2017
@marcotroisi
Copy link
Contributor Author

The first thing to do is something like this. A general HTTP handler based on gorilla mux's routes.

@marcotroisi
Copy link
Contributor Author

marcotroisi commented Mar 23, 2017

Currently getting {"error":"EOF"} when running a simple curl -X GET localhost:8080/user/2`. Possibly something is not right with the response, and perhaps we're not printing anything. Need to investigate.

@marcotroisi
Copy link
Contributor Author

PR: #35

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant