Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Consider splitting Spring auto-config module for client/server #42

Open
shakuzen opened this issue Dec 2, 2020 · 1 comment
Open

Consider splitting Spring auto-config module for client/server #42

shakuzen opened this issue Dec 2, 2020 · 1 comment
Labels
enhancement New feature or request module: spring
Milestone

Comments

@shakuzen
Copy link
Member

shakuzen commented Dec 2, 2020

With both together, it means non-web applications that just want the client auto-configuration have the server dependencies pulled in which causes Spring Boot to configure them as a web app. Currently, the workaround would be to exclude the server artifact prometheus-rsocket-proxy-server from the prometheus-rsocket-spring dependency.

@shakuzen shakuzen added enhancement New feature or request module: spring labels Dec 2, 2020
@shakuzen shakuzen added this to the 1.4.0 milestone Dec 2, 2020
@shakuzen shakuzen modified the milestones: 1.4.0, 1.x Feb 3, 2022
@jonatan-ivanov
Copy link
Member

fyi: Spring Batch users are experiencing this, here is a reproducer: https://github.com/cppwfs/batch-metrics

The workaround is excluding the component that you need. In case of an app that wants to use the client and does not want to be converted to a web app:

<dependency>
	<groupId>io.micrometer.prometheus</groupId>
	<artifactId>prometheus-rsocket-spring</artifactId>
	<version>1.4.0</version>
	<exclusions>
		<exclusion>
			<groupId>io.micrometer.prometheus</groupId>
			<artifactId>prometheus-rsocket-proxy-server</artifactId>
		</exclusion>
	</exclusions>
</dependency>

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request module: spring
Projects
None yet
Development

No branches or pull requests

2 participants