From aef07d75a4888c75274767fe62dd0739c5b0c965 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Thu, 21 Sep 2023 16:15:44 -0700 Subject: [PATCH] Fix HelperLaneTest (Aug '23 release version) Add `-opt-disable sink` to HelperLaneTest shader compilation to prevent sinking of `ddx_fine`/`ddy_fine` intrinsics into flow control. Separate issue has been filed to track down the root of the problem: #5744: Intrinsics ddx_fine/ddy_fine should not be allowed to sink into flow control --- tools/clang/unittests/HLSLExec/ExecutionTest.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/clang/unittests/HLSLExec/ExecutionTest.cpp b/tools/clang/unittests/HLSLExec/ExecutionTest.cpp index 830ada62c8..f864500402 100644 --- a/tools/clang/unittests/HLSLExec/ExecutionTest.cpp +++ b/tools/clang/unittests/HLSLExec/ExecutionTest.cpp @@ -10897,9 +10897,9 @@ TEST_F(ExecutionTest, HelperLaneTest) { st::ParseShaderOpSetFromStream(pStream, ShaderOpSet.get()); #ifdef ISHELPERLANE_PLACEHOLDER - string args = "-DISHELPERLANE_PLACEHOLDER"; + string args = "-DISHELPERLANE_PLACEHOLDER -opt-disable sink"; #else - string args = ""; + string args = "-opt-disable sink"; #endif D3D_SHADER_MODEL TestShaderModels[] = { D3D_SHADER_MODEL_6_0, D3D_SHADER_MODEL_6_6 };