Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Incorrect key for SSL 3.0 rules in SqlServer-2016-Instance.*.xml #668

Closed
General-Fault opened this issue Jul 10, 2020 · 1 comment
Closed
Assignees

Comments

@General-Fault
Copy link

General-Fault commented Jul 10, 2020

Describe the bug
The following rules are referencing an incorrect registry key. They should be updating
HKLM\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\SSL 3.0
However they instead reference
HKLM\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 3.0

The incorrect text is rooted in
source\StigData\Archive\SQL Server\U_MS_SQL_Server_2016_Instance_STIG_V1R7_Manual-xccdf.log
source\StigData\Archive\SQL Server\U_MS_SQL_Server_2016_Instance_STIG_V1R8_Manual-xccdf.log

The incorrect key is found in all versions of the SqlServer-2016-Instance xml files for rules:
V-97521.d
V-97521.h
V-97521.l
V-97521.p

To Reproduce

  1. Create a basic configuration containing a SqlServer resource with the SqlRole = "Instance".
Configuration TestConfig {
    Import-DscResource -ModuleName 'PowerSTIG' -ModuleVersion '4.3.0'

    Node localhost {
      
        SqlServer DatabaseSettings {
            SqlVersion = '2016'
            SqlRole = 'Instance'
            ServerInstance = '.\DatabaseInstance'
            Database = 'master'
        }
    }
}
  1. Compile the configuration `TestConfig -Verbose
  2. Open the generated localhost.mof file
  3. Search for "TLS 3.0"

Expected behavior
All references of "TLS 3.0" should be "SSL 3.0".

@General-Fault General-Fault changed the title Incorrect key for TLS 1.2 rules in SqlServer-2016-Instance.*.xml Incorrect key for SSL 3.0 rules in SqlServer-2016-Instance.*.xml Jul 10, 2020
@bcwilhite bcwilhite self-assigned this Jul 14, 2020
@bcwilhite
Copy link
Contributor

Fix will be released in 4.5.x

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants