Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[launcher] - Win+R seems to conflict with WW #2035

Closed
crutkas opened this issue Apr 9, 2020 · 6 comments
Closed

[launcher] - Win+R seems to conflict with WW #2035

crutkas opened this issue Apr 9, 2020 · 6 comments
Assignees
Labels
Issue-Bug Something isn't working Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone

Comments

@crutkas
Copy link
Member

crutkas commented Apr 9, 2020

When I execute Win+R, launcher doesn't stay open and it also tries to open WW. When I hold Win+R, it keeps the search box open but starts to open shortcut guide and window walker

WinR Open

workaround is to disable WW.

@crutkas crutkas added Issue-Bug Something isn't working Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-PowerToys Run Improved app launch PT Run (Win+R) Window labels Apr 9, 2020
@crutkas crutkas added this to the Build 2020 milestone Apr 9, 2020
@koppor
Copy link

koppor commented Apr 10, 2020

Same for AutoHotkey and macros bound to Win+C or Win+B. If the key combindation is pressed, the action is done. If the key is released, Window Walker pops up.

Example macro:

#b::
IfWinNotExist, ahk_exe firefox.exe
{
  Run C:\Program Files (x86)\Mozilla Firefox\firefox.exe
  WinWait ahk_exe firefox.exe
}
WinActivate
return

@betsegaw
Copy link
Contributor

betsegaw commented Apr 11, 2020

If I understand correctly @crutkas, this only happens when Power Launcher is up right? Since we are going to be working to move this into Power Launcher, the launch bugs won't matter that much.

We will see how much progress I can make this weekend.

@crutkas
Copy link
Member Author

crutkas commented Apr 12, 2020

Yes. But I am very interested in why this is happening. Which code base is the offending as it could impact other apps.

@alekhyareddy28
Copy link
Contributor

This is happening because of the code in the shell plugin.

image

The Shell plugin has it's own code to override the Win+R key and because of the way they are creating and handling hooks (not completely sure how they're doing it), once we press Win+R, the Win key must be pressed again to release it (second if statement). So basically, they're trying to simulate the Win key press, however since simulating only the win key press would pop up the start menu, they are simulating Win+Ctrl which is the same shortcut as that of ww.

To unblock us and mitigate this issue for now, I tried to use the BackSpace keystroke instead of Control, so we would be simulating a Win+BackSpace keystroke and it works fine.

@ryanbodrug-microsoft, @betsegaw and @crutkas any thoughts? I understand the proper way would be to figure out how they're handling hooks and why they're facing this issue.

@crutkas
Copy link
Member Author

crutkas commented Apr 15, 2020

Our keystroke override code should be a single spot. i would remove the wox code path IMO.

@alekhyareddy28 alekhyareddy28 added Status-In progress This issue or work-item is under development Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Apr 20, 2020
@alekhyareddy28
Copy link
Contributor

I've put in a hack for now by simulating the Win+Back keypress.
Created an issue to clean up the way in which keyboard shortcuts are handled and to keep them in sync with the rest of powerToys - #2325.

@crutkas crutkas closed this as completed Apr 26, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Issue-Bug Something isn't working Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

6 participants