Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PowerToys Run (on master)] Search box does not appear in focus if you Alt+Space after interacting with anything else #4270

Closed
arjunbalgovind opened this issue Jun 11, 2020 · 9 comments
Assignees
Labels
Issue-Bug Something isn't working Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone

Comments

@arjunbalgovind
Copy link
Contributor

After the changes to the hotkey implementation in #3825 , if you Alt+Space to show launcher, then click away, whenever you Alt+Space again the text input will not be in focus until you click inside the box again.

Don't have a 100% reliable repro yet, but it involves the above steps plus just clicking around on some other applications and typing text.

@arjunbalgovind arjunbalgovind added Issue-Bug Something isn't working Product-PowerToys Run Improved app launch PT Run (Win+R) Window labels Jun 11, 2020
@saahmedm saahmedm added the Priority-0 Bugs that we consider release-blocking/recall-class (P0) label Jun 12, 2020
@saahmedm saahmedm added this to the InVEST-2006 milestone Jun 12, 2020
@saahmedm
Copy link
Contributor

Could this be because another app has a text box in focus? (@crutkas #swag) @somil55

@arjunbalgovind arjunbalgovind self-assigned this Jun 12, 2020
@arjunbalgovind arjunbalgovind added the Status-In progress This issue or work-item is under development label Jun 12, 2020
@arjunbalgovind
Copy link
Contributor Author

The most reliable repro I've found so far is:

  • Alt Space once to confirm that it is in focus, then alt+space to hide it.
  • Open and close start menu by pressing the Windows logo on the bottom left corner. Before clicking anywhere else, hit Alt+Space. It won't be in focus

@arjunbalgovind
Copy link
Contributor Author

It seems like if you click on the Start menu button to open and close it, the keyboard focus is on the taskbar, and for some reason it doesn't shift to launcher. @somil55 any insight on why this might happen?

@dsrivastavv
Copy link
Contributor

@arjunbalgovind I am not able to repro using the steps you mentioned. The earlier focus issue was because there was a code path in which activate() wasn't being called. Activate() is required to bring the WPF window to the foreground and then you can set focus on the search box.

@arjunbalgovind
Copy link
Contributor Author

It should be repro-able. After clicking the start menu button and clicking it again to close it (not with Win key and not by pressing somewhere else on the desktop or any other window). Also when you Alt+Space after that the cursor still appears indicating that you can type, but when you type nothing happens because it doesn't have keyboard focus.

@arjunbalgovind
Copy link
Contributor Author

I also noticed that if I use Alt+Space and open PT Run, when I click away in the desktop it doesn't disappear. I need to either type something or I have to click inside the box to prevent that. In all these situations the cursor still appears in the search box as if it is in keyboard focus.

@arjunbalgovind
Copy link
Contributor Author

#3469 is related to this.

@crutkas crutkas added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Jun 22, 2020
@crutkas
Copy link
Member

crutkas commented Jun 30, 2020

Fixed in 0.19.0, please visit https://github.com/microsoft/PowerToys/releases/ for the latest release

@crutkas crutkas closed this as completed Jun 30, 2020
@eustachi0
Copy link

After updating to v0.19 I have now this issue about the search on powertoys run being out of focus, especially after launching apps, so I have to click on the search box to type for a new search. It was working fine in the previous version.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Issue-Bug Something isn't working Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

5 participants